Conversation
majst01
force-pushed
the
infra-service-ping
branch
from
caaeba7 to
76723ed
Compare
majst01
force-pushed
the
infra-service-ping
branch
6 times, most recently
from
8dbaa92 to
09b6160
Compare
majst01
commented
Feb 18, 2026
| message ComponentServicePingResponse {} | ||
|
|
||
| // ComponentType defines which service is actually pinging | ||
| enum ComponentType { |
Contributor
Author
There was a problem hiding this comment.
Not sure if we should put this message and the admin.v2.Component message into api.v2 ?
majst01
force-pushed
the
infra-service-ping
branch
from
09b6160 to
e443c6d
Compare
iljarotar
reviewed
Feb 19, 2026
| // ComponentService serves component, e.g. microservices related functions. | ||
| service ComponentService { | ||
| // Ping must be called from every connected microservice in a recurring manner | ||
| // to get visibility of all required microservices. |
Contributor
There was a problem hiding this comment.
Suggested change
| // to get visibility of all required microservices. | |
| // to get visibility of all registered microservices. |
iljarotar
reviewed
Feb 19, 2026
| COMPONENT_TYPE_METAL_CONSOLE = 5 [(metalstack.api.v2.enum_string_value) = "metal-console"]; | ||
| // COMPONENT_TYPE_METAL_METRICS_EXPORTER is metal-metrics-exporter | ||
| COMPONENT_TYPE_METAL_METRICS_EXPORTER = 6 [(metalstack.api.v2.enum_string_value) = "metal-metrics-exporter"]; | ||
| // TODO what about gepm, ccm, etc. I would allow them to call this service but would not introduce |
iljarotar
reviewed
Feb 19, 2026
| // Delete a component | ||
| rpc Delete(ComponentServiceDeleteRequest) returns (ComponentServiceDeleteResponse) { | ||
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_EDITOR; | ||
| option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_VIEWER; |
Contributor
There was a problem hiding this comment.
only editor and include auditing
iljarotar
reviewed
Feb 19, 2026
|
|
||
| // Component represents a microservice connected to our apiserver | ||
| message Component { | ||
| // UUID identifies this component event |
Contributor
There was a problem hiding this comment.
Suggested change
| // UUID identifies this component event | |
| // UUID identifies this component |
iljarotar
reviewed
Feb 19, 2026
|
|
||
| // ComponentQuery to query components | ||
| message ComponentQuery { | ||
| // UUID identifies this component event |
Contributor
There was a problem hiding this comment.
Suggested change
| // UUID identifies this component event | |
| // UUID identifies this component |
majst01
force-pushed
the
infra-service-ping
branch
4 times, most recently
from
31eb835 to
6645c4d
Compare
majst01
force-pushed
the
infra-service-ping
branch
5 times, most recently
from
b401d8b to
4849676
Compare
majst01
force-pushed
the
infra-service-ping
branch
from
4849676 to
c05d8ed
Compare
iljarotar
approved these changes
Feb 20, 2026
majst01
force-pushed
the
infra-service-ping
branch
from
c05d8ed to
e360d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a ping which every microservice which is connected to the metal-apiserver should call at a regular interval.
Admins can then inspect which services are running and see how long they have been up and which token they have in use and how long this token is valid.